Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: lakectl identity nil email panic #8342

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix: lakectl identity nil email panic #8342

merged 1 commit into from
Nov 4, 2024

Conversation

ItamarYuran
Copy link
Contributor

Closes #8340
Slightly adjusted the code.
checking for nil value before using the email.

@ItamarYuran ItamarYuran linked an issue Nov 4, 2024 that may be closed by this pull request
lakectl identity fails on nil Email #8340
Closed
@ItamarYuran ItamarYuran added the exclude-changelog PR description should not be included in next release changelog label Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

E2E Test Results - Quickstart

11 passed

itaiad200
itaiad200 requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

  1. Please change the PR title to something more meaningful
  2. Add a test for the bug to catch regressions

@ItamarYuran ItamarYuran changed the title fixed bugs Identity feature bug fix Nov 4, 2024
@itaiad200 itaiad200 changed the title Identity feature bug fix Fix: lakectl identity nil email panic Nov 4, 2024
@ItamarYuran ItamarYuran merged commit aec8edb into master Nov 4, 2024
43 of 44 checks passed
@ItamarYuran ItamarYuran deleted the 8340-lakectl-identity-fails-on-nil-email branch November 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaiad200 itaiad200 itaiad200 approved these changes

Assignees
No one assigned
Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lakectl identity fails on nil Email
2 participants
@ItamarYuran @itaiad200